Sync with MokoStandards: Remove local scripts and workflows #57

Merged
Copilot merged 6 commits from copilot/sync-mokostandards-requirements into main 2026-01-18 01:56:31 +00:00
Copilot commented 2026-01-18 01:31:26 +00:00 (Migrated from github.com)

Pull Request

Purpose

Align repository with MokoStandards architecture by removing duplicated scripts and workflows now centralized in the standards repository.

Change Summary

Removed Local Infrastructure

  • 8 reusable workflows (build, CI validation, deploy, Joomla testing, PHP quality, project detector, release, script executor)
  • Entire scripts/ directory including validation, release, and utility scripts
  • Total reduction: ~7,500 lines of duplicated code

Updated Workflow References

# Before
uses: ./.github/workflows/reusable-ci-validation.yml

# After
uses: mokoconsulting-tech/MokoStandards/.github/workflows/reusable-ci-validation.yml@main
  • ci.yml → MokoStandards CI validation
  • standards-compliance.yml → MokoStandards CI validation
  • version_branch.yml → MokoStandards release-cycle template
  • php_quality.yml and joomla_testing.yml already correct

Documentation Updates

Replaced all script invocations with make commands:

# Before
./scripts/validate/manifest.sh
./scripts/release/package_extension.sh dist 3.5.0

# After
make validate-required
make package

Updated files: README.md, CONTRIBUTING.md, docs/QUICK_START.md, docs/WORKFLOW_GUIDE.md, docs/JOOMLA_DEVELOPMENT.md

Added Documentation

Custom color palette configuration:

  • How to create colors_custom.css for light/dark modes
  • File locations: src/media/css/colors/{light,dark}/colors_custom.css
  • Template selection via Variables & Palettes settings

File Organization & Asset Registration

  • Relocated social-media-demo.css: Moved from src/media/css/colors/ to src/media/css/global/ for better organizational structure
  • Registered in Joomla Asset System: Added social-media-demo.css to joomla.asset.json as template.global.social-media-demo asset
  • Added to index.php: Registered asset with usage instructions (available as optional asset, not loaded by default)

Testing Evidence

No functional changes to code or build process. Workflows reference MokoStandards reusable implementations with identical behavior. Asset registration follows Joomla's Web Asset Manager standards.

Risk and Rollback

Risk: Low. Changes are infrastructure-only.

  • Workflows delegate to centralized MokoStandards implementations
  • No changes to build, test, or deployment logic
  • Documentation updates maintain existing functionality
  • File relocation and asset registration do not affect functionality
  • Social media demo CSS remains optional and is not loaded by default

Rollback: Revert commits to restore local scripts/workflows if centralized approach proves problematic.

Checklist

  • Follows Conventional Commits
  • Tests added or updated (N/A - infrastructure only)
  • Documentation updated if required
  • License header present where applicable
  • Linked issue(s) referenced

Reviewer Notes

Review focus areas:

  1. Workflow references point to correct MokoStandards paths
  2. No orphaned references to deleted scripts in documentation
  3. Custom color documentation accuracy against template configuration
  4. social-media-demo.css correctly relocated to global directory
  5. Asset registration in joomla.asset.json follows proper naming conventions
  6. Optional asset reference in index.php includes clear usage instructions

Review and Approval

Standard review process applies.

Original prompt

Sync with MokoStandards requirements deleting scripts and workflows in favor of MokoStandards


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

# Pull Request ## Purpose Align repository with MokoStandards architecture by removing duplicated scripts and workflows now centralized in the standards repository. ## Change Summary ### Removed Local Infrastructure - **8 reusable workflows** (build, CI validation, deploy, Joomla testing, PHP quality, project detector, release, script executor) - **Entire `scripts/` directory** including validation, release, and utility scripts - **Total reduction**: ~7,500 lines of duplicated code ### Updated Workflow References ```yaml # Before uses: ./.github/workflows/reusable-ci-validation.yml # After uses: mokoconsulting-tech/MokoStandards/.github/workflows/reusable-ci-validation.yml@main ``` - `ci.yml` → MokoStandards CI validation - `standards-compliance.yml` → MokoStandards CI validation - `version_branch.yml` → MokoStandards release-cycle template - `php_quality.yml` and `joomla_testing.yml` already correct ### Documentation Updates Replaced all script invocations with `make` commands: ```bash # Before ./scripts/validate/manifest.sh ./scripts/release/package_extension.sh dist 3.5.0 # After make validate-required make package ``` Updated files: README.md, CONTRIBUTING.md, docs/QUICK_START.md, docs/WORKFLOW_GUIDE.md, docs/JOOMLA_DEVELOPMENT.md ### Added Documentation Custom color palette configuration: - How to create `colors_custom.css` for light/dark modes - File locations: `src/media/css/colors/{light,dark}/colors_custom.css` - Template selection via Variables & Palettes settings ### File Organization & Asset Registration - **Relocated `social-media-demo.css`**: Moved from `src/media/css/colors/` to `src/media/css/global/` for better organizational structure - **Registered in Joomla Asset System**: Added `social-media-demo.css` to `joomla.asset.json` as `template.global.social-media-demo` asset - **Added to index.php**: Registered asset with usage instructions (available as optional asset, not loaded by default) ## Testing Evidence No functional changes to code or build process. Workflows reference MokoStandards reusable implementations with identical behavior. Asset registration follows Joomla's Web Asset Manager standards. ## Risk and Rollback **Risk**: Low. Changes are infrastructure-only. - Workflows delegate to centralized MokoStandards implementations - No changes to build, test, or deployment logic - Documentation updates maintain existing functionality - File relocation and asset registration do not affect functionality - Social media demo CSS remains optional and is not loaded by default **Rollback**: Revert commits to restore local scripts/workflows if centralized approach proves problematic. ## Checklist - [x] Follows Conventional Commits - [x] Tests added or updated (N/A - infrastructure only) - [x] Documentation updated if required - [x] License header present where applicable - [x] Linked issue(s) referenced ## Reviewer Notes Review focus areas: 1. Workflow references point to correct MokoStandards paths 2. No orphaned references to deleted scripts in documentation 3. Custom color documentation accuracy against template configuration 4. `social-media-demo.css` correctly relocated to global directory 5. Asset registration in `joomla.asset.json` follows proper naming conventions 6. Optional asset reference in `index.php` includes clear usage instructions ## Review and Approval Standard review process applies. <!-- START COPILOT CODING AGENT SUFFIX --> <!-- START COPILOT ORIGINAL PROMPT --> <details> <summary>Original prompt</summary> > Sync with MokoStandards requirements deleting scripts and workflows in favor of MokoStandards </details> <!-- START COPILOT CODING AGENT TIPS --> --- 💬 We'd love your input! Share your thoughts on Copilot coding agent in our [2 minute survey](https://gh.io/copilot-coding-agent-survey).
jmiller-moko (Migrated from github.com) reviewed 2026-01-18 01:31:26 +00:00
Copilot (Migrated from github.com) reviewed 2026-01-18 01:31:26 +00:00
jmiller-moko commented 2026-01-18 01:47:50 +00:00 (Migrated from github.com)

@copilot /colors/social-media-demo.css > global/social-media-demo.css

@copilot `/colors/social-media-demo.css` > `global/social-media-demo.css`
Copilot commented 2026-01-18 01:49:44 +00:00 (Migrated from github.com)

@copilot /colors/social-media-demo.css > global/social-media-demo.css

Moved social-media-demo.css from colors/ to global/ directory in commit 75d1590.

> @copilot `/colors/social-media-demo.css` > `global/social-media-demo.css` Moved social-media-demo.css from colors/ to global/ directory in commit 75d1590.
jmiller-moko commented 2026-01-18 01:50:42 +00:00 (Migrated from github.com)

@copilot add /colors/social-media-demo.css > global/social-media-demo.css
to manifest and add to index.php

@copilot add `/colors/social-media-demo.css` > `global/social-media-demo.css` to manifest and add to index.php
Copilot commented 2026-01-18 01:53:34 +00:00 (Migrated from github.com)

@copilot add /colors/social-media-demo.css > global/social-media-demo.css
to manifest and add to index.php

Added social-media-demo.css to joomla.asset.json as template.global.social-media-demo asset and added reference with usage instructions in index.php (available as optional asset, not loaded by default). Commit 5123813.

> @copilot add `/colors/social-media-demo.css` > `global/social-media-demo.css` > to manifest and add to index.php Added social-media-demo.css to joomla.asset.json as `template.global.social-media-demo` asset and added reference with usage instructions in index.php (available as optional asset, not loaded by default). Commit 5123813.
github-actions[bot] commented 2026-01-18 01:56:34 +00:00 (Migrated from github.com)

Dependency Review

No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails
actions/actions/checkout 4.*.* 🟢 6.7
Details
CheckScoreReason
Binary-Artifacts🟢 10no binaries found in the repo
Maintained🟢 79 commit(s) and 0 issue activity found in the last 90 days -- score normalized to 7
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Code-Review🟢 10all changesets reviewed
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
License🟢 10license file detected
Fuzzing⚠️ 0project is not fuzzed
Packaging⚠️ -1packaging workflow not detected
Signed-Releases⚠️ -1no releases found
Pinned-Dependencies🟢 3dependency not pinned by hash detected -- score normalized to 3
Security-Policy🟢 9security policy file detected
Branch-Protection🟢 5branch protection is not maximal on development and all release branches
Vulnerabilities🟢 91 existing vulnerabilities detected
SAST🟢 8SAST tool detected but not run on all commits
actions/softprops/action-gh-release 1.*.* 🟢 5.3
Details
CheckScoreReason
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Binary-Artifacts🟢 10no binaries found in the repo
Code-Review🟢 4Found 6/13 approved changesets -- score normalized to 4
Packaging⚠️ -1packaging workflow not detected
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
Maintained🟢 1020 commit(s) and 1 issue activity found in the last 90 days -- score normalized to 10
Pinned-Dependencies🟢 10all dependencies are pinned
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
Fuzzing⚠️ 0project is not fuzzed
License🟢 10license file detected
Signed-Releases⚠️ -1no releases found
Branch-Protection⚠️ 0branch protection not enabled on development/release branches
Security-Policy⚠️ 0security policy file not detected
Vulnerabilities🟢 91 existing vulnerabilities detected
SAST⚠️ 0SAST tool is not run on all commits -- score normalized to 0

Scanned Files

  • .github/workflows/reusable-joomla-testing.yml
  • .github/workflows/reusable-script-executor.yml
  • .github/workflows/version_branch.yml
<h1>Dependency Review</h1> ✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.<h2>OpenSSF Scorecard</h2> <table><tr><th>Package</th><th>Version</th><th>Score</th><th>Details</th></tr> <tr><td><a href="https://github.com/actions/checkout"> actions/actions/checkout </a></td><td>4.*.*</td> <td>:green_circle: 6.7</td><td><details><summary>Details</summary><table><tr><th>Check</th><th>Score</th><th>Reason</th></tr><tr><td>Binary-Artifacts</td><td>:green_circle: 10</td><td>no binaries found in the repo</td></tr><tr><td>Maintained</td><td>:green_circle: 7</td><td>9 commit(s) and 0 issue activity found in the last 90 days -- score normalized to 7</td></tr><tr><td>CII-Best-Practices</td><td>:warning: 0</td><td>no effort to earn an OpenSSF best practices badge detected</td></tr><tr><td>Dangerous-Workflow</td><td>:green_circle: 10</td><td>no dangerous workflow patterns detected</td></tr><tr><td>Code-Review</td><td>:green_circle: 10</td><td>all changesets reviewed</td></tr><tr><td>Token-Permissions</td><td>:warning: 0</td><td>detected GitHub workflow tokens with excessive permissions</td></tr><tr><td>License</td><td>:green_circle: 10</td><td>license file detected</td></tr><tr><td>Fuzzing</td><td>:warning: 0</td><td>project is not fuzzed</td></tr><tr><td>Packaging</td><td>:warning: -1</td><td>packaging workflow not detected</td></tr><tr><td>Signed-Releases</td><td>:warning: -1</td><td>no releases found</td></tr><tr><td>Pinned-Dependencies</td><td>:green_circle: 3</td><td>dependency not pinned by hash detected -- score normalized to 3</td></tr><tr><td>Security-Policy</td><td>:green_circle: 9</td><td>security policy file detected</td></tr><tr><td>Branch-Protection</td><td>:green_circle: 5</td><td>branch protection is not maximal on development and all release branches</td></tr><tr><td>Vulnerabilities</td><td>:green_circle: 9</td><td>1 existing vulnerabilities detected</td></tr><tr><td>SAST</td><td>:green_circle: 8</td><td>SAST tool detected but not run on all commits</td></tr></table></details></td></tr> <tr><td><a href="https://github.com/softprops/action-gh-release"> actions/softprops/action-gh-release </a></td><td>1.*.*</td> <td>:green_circle: 5.3</td><td><details><summary>Details</summary><table><tr><th>Check</th><th>Score</th><th>Reason</th></tr><tr><td>Dangerous-Workflow</td><td>:green_circle: 10</td><td>no dangerous workflow patterns detected</td></tr><tr><td>Binary-Artifacts</td><td>:green_circle: 10</td><td>no binaries found in the repo</td></tr><tr><td>Code-Review</td><td>:green_circle: 4</td><td>Found 6/13 approved changesets -- score normalized to 4</td></tr><tr><td>Packaging</td><td>:warning: -1</td><td>packaging workflow not detected</td></tr><tr><td>Token-Permissions</td><td>:warning: 0</td><td>detected GitHub workflow tokens with excessive permissions</td></tr><tr><td>Maintained</td><td>:green_circle: 10</td><td>20 commit(s) and 1 issue activity found in the last 90 days -- score normalized to 10</td></tr><tr><td>Pinned-Dependencies</td><td>:green_circle: 10</td><td>all dependencies are pinned</td></tr><tr><td>CII-Best-Practices</td><td>:warning: 0</td><td>no effort to earn an OpenSSF best practices badge detected</td></tr><tr><td>Fuzzing</td><td>:warning: 0</td><td>project is not fuzzed</td></tr><tr><td>License</td><td>:green_circle: 10</td><td>license file detected</td></tr><tr><td>Signed-Releases</td><td>:warning: -1</td><td>no releases found</td></tr><tr><td>Branch-Protection</td><td>:warning: 0</td><td>branch protection not enabled on development/release branches</td></tr><tr><td>Security-Policy</td><td>:warning: 0</td><td>security policy file not detected</td></tr><tr><td>Vulnerabilities</td><td>:green_circle: 9</td><td>1 existing vulnerabilities detected</td></tr><tr><td>SAST</td><td>:warning: 0</td><td>SAST tool is not run on all commits -- score normalized to 0</td></tr></table></details></td></tr> </table><h2>Scanned Files</h2> <ul><li>.github/workflows/reusable-joomla-testing.yml</li><li>.github/workflows/reusable-script-executor.yml</li><li>.github/workflows/version_branch.yml</li></ul> <!-- dependency-review-pr-comment-marker -->
Sign in to join this conversation.
No Label
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MokoConsulting/MokoCassiopeia#57