MokoConsulting/MokoGitea-Fork
1
0
Fork 0
Code Issues 156 Pull Requests Releases 96 Wiki Activity

feat: remove display_name, compute from extension_type + name (#650) #652

Closed
jmiller wants to merge 2 commits from fix/650-display-name-computed into main
pull from: fix/650-display-name-computed
merge into: :main
Conversation 0 Commits 2 Files Changed 15
+45 -26
jmiller commented 2026-06-19 09:06:51 +00:00
Owner
Copy Link
Copy Source

Summary

  • Remove DisplayName field from RepoMetadata and UpdateStreamConfig structs
  • Add DerivedDisplayName() method: "{Type} - {Name}" (e.g. Package - MokoSuiteBackup)
  • API returns computed display_name in GET response, ignores it on PUT
  • Update server feeds use DerivedDisplayName() instead of stored value
  • Remove display_name from web forms (repo licensing, org update streams)
  • License settings API computes display_name from repo metadata
  • Migration v358: drop display_name columns from both tables

Files Changed (13)

  • models/repo/repo_manifest.go — Remove field, add DerivedDisplayName()
  • models/updateserver/update_stream_config.go — Remove field
  • models/migrations/v1_27/v358.go — Drop columns migration
  • models/migrations/migrations.go — Register migration
  • routers/api/v1/repo/manifest.go — Use computed in GET, strip from PUT
  • routers/api/v1/repo/license_key.go — Compute from repo metadata
  • routers/web/repo/setting/setting.go — Remove form field
  • routers/web/repo/setting/metadata.go — Remove preservation
  • routers/web/org/update_streams.go — Remove form field
  • services/forms/repo_form.go — Remove form struct field
  • services/updateserver/joomla.go — Use DerivedDisplayName()
  • templates/repo/settings/licensing.tmpl — Remove input
  • templates/org/settings/update_streams.tmpl — Remove input

Closes

Coordinated With

## Summary - Remove `DisplayName` field from `RepoMetadata` and `UpdateStreamConfig` structs - Add `DerivedDisplayName()` method: `"{Type} - {Name}"` (e.g. `Package - MokoSuiteBackup`) - API returns computed `display_name` in GET response, ignores it on PUT - Update server feeds use `DerivedDisplayName()` instead of stored value - Remove `display_name` from web forms (repo licensing, org update streams) - License settings API computes `display_name` from repo metadata - Migration v358: drop `display_name` columns from both tables ## Files Changed (13) - `models/repo/repo_manifest.go` — Remove field, add `DerivedDisplayName()` - `models/updateserver/update_stream_config.go` — Remove field - `models/migrations/v1_27/v358.go` — Drop columns migration - `models/migrations/migrations.go` — Register migration - `routers/api/v1/repo/manifest.go` — Use computed in GET, strip from PUT - `routers/api/v1/repo/license_key.go` — Compute from repo metadata - `routers/web/repo/setting/setting.go` — Remove form field - `routers/web/repo/setting/metadata.go` — Remove preservation - `routers/web/org/update_streams.go` — Remove form field - `services/forms/repo_form.go` — Remove form struct field - `services/updateserver/joomla.go` — Use `DerivedDisplayName()` - `templates/repo/settings/licensing.tmpl` — Remove input - `templates/org/settings/update_streams.tmpl` — Remove input ## Closes - #650 ## Coordinated With - mcp-mokogitea-api #17 / PR #19 - mokoplatform #259 / PR #261
jmiller added 1 commit 2026-06-19 09:06:52 +00:00
feat: remove display_name, compute from extension_type + name (#650)
Branch Policy Check / Verify merge target (pull_request) Failing after 1s
Details
Universal: PR Check / Branch Policy (pull_request) Failing after 1s
Details
Generic: Repo Health / Site Health (pull_request) Has been skipped
Details
Generic: Repo Health / Access control (pull_request) Successful in 1s
Details
Universal: PR Check / Validate PR (pull_request) Failing after 9s
Details
Generic: Project CI / Lint & Validate (pull_request) Successful in 34s
Details
PR RC Release / Build RC Release (pull_request) Failing after 1m17s
Details
Universal: Secret Scanning / Gitleaks Secret Scan (pull_request) Successful in 1m18s
Details
Universal: Pre-Release / Build Pre-Release (${{ inputs.stability || github.ref_name }}) (push) Successful in 2m22s
Details
Universal: Build & Release / Promote to RC (pull_request) Successful in 26s
Details
Universal: Build & Release / Build & Release Pipeline (pull_request) Has been skipped
Details
Generic: Project CI / Tests (pull_request) Has been cancelled
Details
Universal: PR Check / Build RC Package (pull_request) Has been cancelled
Details
Universal: PR Check / Report Issues (pull_request) Has been cancelled
Details
Generic: Repo Health / Scripts governance (pull_request) Has been cancelled
Details
Generic: Repo Health / Repository health (pull_request) Has been cancelled
Details
Generic: Repo Health / Report Issues (pull_request) Has been cancelled
Details
527b69555a 
- Remove DisplayName field from RepoMetadata and UpdateStreamConfig
- Add DerivedDisplayName() method: "{Type} - {Name}" (e.g. "Package - MokoSuiteBackup")
- API returns computed display_name in GET, ignores it on PUT
- Update server feeds use DerivedDisplayName() instead of stored value
- Remove display_name from web forms (repo licensing, org update streams)
- License settings API computes display_name from repo metadata
- Migration v358: drop display_name columns from both tables
jmiller added 1 commit 2026-06-19 09:06:58 +00:00
chore(version): pre-release bump to 06.18.01-dev [skip ci] fd41da0eb6
jmiller closed this pull request 2026-06-19 09:09:13 +00:00
jmiller deleted branch fix/650-display-name-computed 2026-06-19 09:09:13 +00:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
breaking-change
Breaking API or behavior change
 ci-cd
CI/CD pipeline changes
 config
Configuration changes
 dependencies
Dependency updates
 deploy-failure
Deployment failed
 docker
Docker/container changes
 documentation
Documentation changes
 feature: wiki
Wiki system enhancements
 good first issue
Good for newcomers
 health-check
Repo health check result
 help wanted
Extra attention needed
 mokostandards
Related to MokoStandards framework
 push-failure
Git push operation failed
 security
Security vulnerability or hardening
 size/l
200-500 lines changed
 size/m
50-200 lines changed
 size/s
10-50 lines changed
 size/xl
500+ lines changed
 size/xs
< 10 lines changed
 standards-drift
Deviates from MokoStandards
 standards-update
MokoStandards compliance update
 sync-failure
Sync or mirror failed
 tech-debt
Technical debt and TODO/FIXME items
 upstream
upstream
Inherited from upstream Gitea
 work-in-progress
Draft or incomplete work
No labels
Priority -
Type -
Milestone
No items
No Milestone
Assignees
Clear assignees
jmiller (Jonathan Miller) moko-deploy (Moko Deploy Bot)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MokoConsulting/MokoGitea-Fork#652
Delete Branch "fix/650-display-name-computed"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?