MokoConsulting/MokoGitea-Fork
1
0
Fork 0
Code Issues 136 Pull Requests Releases 96 Wiki Activity

chore(manifest): remove deprecated .mokogitea/manifest.xml parser; mokoplatform→mokocli #754

Merged
jmiller merged 2 commits from feature/752-chore-deploy-rebuild-redeploy-for-moko-p into dev 2026-07-06 02:38:22 +00:00
Conversation 0 Commits 2 Files Changed 6
+23 -142
jmiller commented 2026-07-06 02:02:47 +00:00
Owner
Copy Link
Copy Source

Part of #752 (forge-rebrand gate). .mokogitea/manifest.xml is deprecated — the first-class RepoMetadata DB fields are the authoritative repository metadata (see #752 comment). So rather than teach the XML parser the renamed mokocli root element, remove the dead XML auto-sync path and rebrand the remaining mokoplatform references.

Changes

  • 🗑️ Delete services/repository/manifest_sync.go (the manifestXML parser + SyncMetadataFromCommit)
  • ➖ Remove the SyncMetadataFromCommit call on default-branch push (push.go)
  • 🏷️ Rebrand mokoplatform→mokocli in repo_manifest.go comments, v347.go comment, and the manifest_desc locale string
  • gofmt-normalized repo_manifest.go struct-tag alignment (pre-existing)

Safety verification (metadata ability + update server)

The XML sync was one of three write paths to the first-class fields; the other two remain, and every reader uses the DB — not the XML:

Write paths preserved (coordinating metadata ability):

  • API — routers/api/v1/repo/manifest.go → CreateOrUpdateRepoMetadata (PUT /repos/{o}/{r}/manifest + /metadata)
  • Web UI — routers/web/repo/setting/metadata.go → CreateOrUpdateRepoMetadata (Settings → Metadata)

Update server / feeds are DB-sourced (unaffected):

  • services/updateserver/joomla.go:190, routers/api/v1/licensing/updates.go:167, routers/web/repo/changelog_xml.go:68, routers/api/v1/repo/license_key.go:27 all read GetRepoMetadata (DB). The Joomla feed sets defaults first and guards if manifest != nil, so it degrades gracefully with no metadata. None read manifest.xml.

Existing repos keep their last-synced DB metadata; going forward metadata changes come via API/UI (the deprecation). Repos' now-dead .mokogitea/manifest.xml files can be cleaned up separately (non-blocking).

Build

go build ./services/repository/... ./models/... → clean; all changed files gofmt-clean.

Not in this PR (remain on #752)

  • The image rebuild + production forge redeploy (gated: backup incl. MySQL keyring, runner/mount preservation, rollback tag) — to be run deliberately.
  • Part 2 workflow clone-URL cutover (needs mirror-name verification).

Refs #752

https://claude.ai/code/session_01Wsno14cxE49MstXFs9G5KT

Part of #752 (forge-rebrand gate). `.mokogitea/manifest.xml` is **deprecated** — the first-class `RepoMetadata` DB fields are the authoritative repository metadata (see #752 comment). So rather than teach the XML parser the renamed `mokocli` root element, **remove the dead XML auto-sync path** and rebrand the remaining `mokoplatform` references. ## Changes - 🗑️ **Delete** `services/repository/manifest_sync.go` (the `manifestXML` parser + `SyncMetadataFromCommit`) - ➖ **Remove** the `SyncMetadataFromCommit` call on default-branch push (`push.go`) - 🏷️ **Rebrand** `mokoplatform`→`mokocli` in `repo_manifest.go` comments, `v347.go` comment, and the `manifest_desc` locale string - `gofmt`-normalized `repo_manifest.go` struct-tag alignment (pre-existing) ## Safety verification (metadata ability + update server) The XML sync was **one of three** write paths to the first-class fields; the other two remain, and every reader uses the DB — not the XML: **Write paths preserved (coordinating metadata ability):** - API — `routers/api/v1/repo/manifest.go` → `CreateOrUpdateRepoMetadata` (`PUT /repos/{o}/{r}/manifest` + `/metadata`) - Web UI — `routers/web/repo/setting/metadata.go` → `CreateOrUpdateRepoMetadata` (Settings → Metadata) **Update server / feeds are DB-sourced (unaffected):** - `services/updateserver/joomla.go:190`, `routers/api/v1/licensing/updates.go:167`, `routers/web/repo/changelog_xml.go:68`, `routers/api/v1/repo/license_key.go:27` all read `GetRepoMetadata` (DB). The Joomla feed sets defaults first and guards `if manifest != nil`, so it degrades gracefully with no metadata. **None read `manifest.xml`.** Existing repos keep their last-synced DB metadata; going forward metadata changes come via API/UI (the deprecation). Repos' now-dead `.mokogitea/manifest.xml` files can be cleaned up separately (non-blocking). ## Build `go build ./services/repository/... ./models/... ` → clean; all changed files gofmt-clean. ## Not in this PR (remain on #752) - The image rebuild + **production forge redeploy** (gated: backup incl. MySQL keyring, runner/mount preservation, rollback tag) — to be run deliberately. - Part 2 workflow clone-URL cutover (needs mirror-name verification). Refs #752 https://claude.ai/code/session_01Wsno14cxE49MstXFs9G5KT
jmiller added 1 commit 2026-07-06 02:02:49 +00:00
chore(manifest): remove deprecated .mokogitea/manifest.xml parser; mokoplatform->mokocli
Universal: Auto Version Bump / Version Bump (push) Successful in 14s
Details
Universal: PR Check / Require Docs Update (pull_request) Has been skipped
Details
Universal: PR Check / Wiki Update Reminder (pull_request) Has been skipped
Details
Universal: PR Check / Branch Policy (pull_request) Successful in 1s
Details
PR RC Release / Build RC Release (pull_request) Successful in 3s
Details
Universal: PR Check / Validate PR (pull_request) Successful in 13s
Details
Generic: Project CI / Lint & Validate (pull_request) Successful in 44s
Details
Universal: PR Check / Secret Scan (pull_request) Successful in 1m38s
Details
Generic: Project CI / Tests (pull_request) Has been cancelled
Details
Universal: PR Check / Build RC Package (pull_request) Has been cancelled
Details
Universal: PR Check / Report Issues (pull_request) Has been cancelled
Details
358606e235 
The .mokogitea/manifest.xml file is deprecated - the first-class RepoMetadata DB
fields (set via the /manifest API) are the authoritative repository metadata (see
issue #752). Remove the legacy XML auto-sync path rather than teaching it the
renamed mokocli root element:

- delete services/repository/manifest_sync.go (manifestXML parser)
- drop the SyncMetadataFromCommit call on default-branch push (push.go)
- rebrand remaining mokoplatform->mokocli refs (repo_manifest.go, v347.go comment,
  locale manifest_desc)

The RepoMetadata model, /manifest API, settings UI, and update-feed generation
(first-class fields) are unchanged. gofmt-normalized repo_manifest.go struct tags.

Refs #752

Claude-Session: https://claude.ai/code/session_01Wsno14cxE49MstXFs9G5KT
jmiller added 1 commit 2026-07-06 02:07:12 +00:00
chore(api): remove /manifest backward-compat alias route (use /metadata)
Universal: PR Check / Require Docs Update (pull_request) Has been skipped
Details
Universal: PR Check / Wiki Update Reminder (pull_request) Has been skipped
Details
Universal: PR Check / Branch Policy (pull_request) Successful in 2s
Details
PR RC Release / Build RC Release (pull_request) Successful in 3s
Details
Universal: PR Check / Validate PR (pull_request) Successful in 14s
Details
Universal: Auto Version Bump / Version Bump (push) Successful in 25s
Details
Generic: Project CI / Lint & Validate (pull_request) Successful in 51s
Details
Universal: PR Check / Secret Scan (pull_request) Successful in 1m21s
Details
RC Revert / Rename rc/ back to dev/ (pull_request) Has been skipped
Details
Branch Cleanup / Delete merged branch (pull_request) Successful in 3s
Details
Generic: Project CI / Tests (pull_request) Has been cancelled
Details
Universal: PR Check / Build RC Package (pull_request) Has been cancelled
Details
Universal: PR Check / Report Issues (pull_request) Has been cancelled
Details
fcf33d35df 
The /manifest GET+PUT routes were backward-compat aliases for the canonical
/metadata routes. Completing the manifest->metadata migration (#752): drop the
alias so /metadata is the single path. Handlers (GetRepoMetadata/UpdateRepoMetadata)
are unchanged. The MCP already calls /metadata (mcp-mokogitea-api v1.4.2,
gitea_metadata_get/update); the stale gitea_manifest_* tools only exist in older
deployed MCP builds and drop out on redeploy.

Refs #752

Claude-Session: https://claude.ai/code/session_01Wsno14cxE49MstXFs9G5KT
jmiller merged commit 36a824be1d into dev 2026-07-06 02:38:22 +00:00
jmiller deleted branch feature/752-chore-deploy-rebuild-redeploy-for-moko-p 2026-07-06 02:38:25 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
breaking-change
Breaking API or behavior change
 ci-cd
CI/CD pipeline changes
 config
Configuration changes
 dependencies
Dependency updates
 deploy-failure
Deployment failed
 docker
Docker/container changes
 documentation
Documentation changes
 feature: wiki
Wiki system enhancements
 good first issue
Good for newcomers
 health-check
Repo health check result
 help wanted
Extra attention needed
 mokostandards
Related to MokoStandards framework
 push-failure
Git push operation failed
 security
Security vulnerability or hardening
 size/l
200-500 lines changed
 size/m
50-200 lines changed
 size/s
10-50 lines changed
 size/xl
500+ lines changed
 size/xs
< 10 lines changed
 standards-drift
Deviates from MokoStandards
 standards-update
MokoStandards compliance update
 sync-failure
Sync or mirror failed
 tech-debt
Technical debt and TODO/FIXME items
 upstream
upstream
Inherited from upstream Gitea
 work-in-progress
Draft or incomplete work
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No labels
Priority -
Type -
Milestone
No items
No Milestone
Assignees
Clear assignees
jmiller (Jonathan Miller) moko-deploy (Moko Deploy Bot)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MokoConsulting/MokoGitea-Fork#754
Delete Branch "feature/752-chore-deploy-rebuild-redeploy-for-moko-p"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?