MokoConsulting/MokoOnyx
1
0
Fork 0
Code Issues 10 Pull Requests Releases 5 Wiki Activity

fix: remove footer bottom padding when social icons in footer #135

Merged
jmiller merged 1 commits from fix/footer-padding-social into dev 2026-06-20 20:32:11 +00:00
Conversation 0 Commits 1 Files Changed 1
+2 -2
jmiller commented 2026-06-20 20:32:00 +00:00
Owner
Copy Link
Copy Source

Summary

  • Override --footer-padding-bottom to 0px when social_footer is enabled
  • The 80px default reserves space for the floating social bar, which isn't needed when icons are inline in the footer

Test plan

  • Enable social_footer — verify no extra padding at bottom of footer
  • Disable social_footer — verify 80px padding remains for floating bar
## Summary - Override `--footer-padding-bottom` to `0px` when `social_footer` is enabled - The 80px default reserves space for the floating social bar, which isn't needed when icons are inline in the footer ## Test plan - [ ] Enable social_footer — verify no extra padding at bottom of footer - [ ] Disable social_footer — verify 80px padding remains for floating bar
jmiller added 1 commit 2026-06-20 20:32:00 +00:00
fix: remove footer bottom padding when social icons are in footer
Generic: Project CI / Tests (pull_request) Blocked by required conditions
Details
Universal: PR Check / Build RC Package (pull_request) Blocked by required conditions
Details
Universal: PR Check / Report Issues (pull_request) Blocked by required conditions
Details
Universal: PR Check / Branch Policy (pull_request) Successful in 1s
Details
Generic: Project CI / Lint & Validate (pull_request) Successful in 11s
Details
RC Revert / Rename rc/ back to dev/ (pull_request) Has been skipped
Details
Branch Cleanup / Delete merged branch (pull_request) Successful in 2s
Details
Universal: PR Check / Validate PR (pull_request) Successful in 30s
Details
Universal: Pre-Release / Build Pre-Release (${{ inputs.stability || 'development' }}) (pull_request) Successful in 13s
Details
9529ab3c9f 
Override --footer-padding-bottom to 0px when social_footer is enabled,
since the 80px default reserves space for the floating social bar.
jmiller merged commit e061e8a5c6 into dev 2026-06-20 20:32:11 +00:00
jmiller deleted branch fix/footer-padding-social 2026-06-20 20:32:12 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
automation
Automated processes or scripts
 breaking-change
Breaking API or functionality change
 build
Build system changes
 ci-cd
CI/CD pipeline changes
 config
Configuration file changes
 css
CSS/styling changes
 dependencies
Dependency updates
 deploy-failure
Automated deploy failure tracking
 docker
Docker configuration changes
 documentation
Documentation changes
 dolibarr
Dolibarr module or extension
 generic
Generic project or library
 good first issue
Good for newcomers
 health-check
Repository health check results
 health: excellent
Health score 90-100
 health: fair
Health score 50-69
 health: good
Health score 70-89
 health: poor
Health score below 50
 help wanted
Extra attention needed
 html
HTML template changes
 javascript
JavaScript code changes
 joomla
Joomla extension or component
 major-release
Major version release
 minor-release
Minor version release
 mokostandards
MokoStandards compliance
 needs-review
Awaiting code review
 patch-release
Patch version release
 php
PHP code changes
 push-failure
File push failure requiring attention
 python
Python code changes
 release-candidate
Release candidate build
 security
Security-related changes
 size/l
Large change (101-300 lines)
 size/m
Medium change (31-100 lines)
 size/s
Small change (11-30 lines)
 size/xl
Extra large change (301-1000 lines)
 size/xs
Extra small change (1-10 lines)
 size/xxl
Extremely large change (1000+ lines)
 standards-drift
Repository drifted from MokoStandards
 standards-update
MokoStandards sync update
 sync-failure
Bulk sync failure requiring attention
 sync-report
Bulk sync run report
 template-validation-failure
Template workflow validation failure
 tests
Test suite changes
 type: bug
Something isn't working
 type: chore
Maintenance tasks
 type: enhancement
Enhancement to existing feature
 type: feature
New feature or request
 type: refactor
Code refactoring
 type: version
Version-related change
 typescript
TypeScript code changes
 version
Version bump or release
 version-drift
Version mismatch detected
 work-in-progress
Work in progress, not ready for merge
No labels
Priority -
Type -
Milestone
No items
No Milestone
Assignees
Clear assignees
jmiller (Jonathan Miller)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MokoConsulting/MokoOnyx#135
Delete Branch "fix/footer-padding-social"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?