Enforce per-profile retention and repair Purge Old Backups button #203

Merged

jmiller merged 1 commits from fix/backup-retention-purge into main 2026-07-04 20:26:21 +00:00

Conversation 0 Commits 1 Files Changed 8

+173 -11

jmiller commented 2026-07-04 19:36:43 +00:00

Owner

Copy Link

Copy Source

Summary

Two related backup-management fixes.

Retention ("records / days to keep")

• The retention fieldset was defined in profile.xml but never rendered in the profile editor, so retention_days/retention_count were invisible. Now rendered on the Archive tab.
• Those columns were read by nothing, so no backup was ever pruned. Added RetentionManager::prune(), called from completeRecord() in both BackupEngine and SteppedBackupEngine after a backup finishes.
  • Policy: delete a complete/warning backup when either it is older than retention_days or it falls outside the newest retention_count copies. 0 = unlimited for that rule. Deleting a record also removes its archive + log file.
• Corrected misleading language/schema text ("use global default" — no such global backup-retention setting exists) to "0 = unlimited".

Purge Old Backups button

• The modal only opened via a fragile selector match on the toolbar button's inline onclick, which Joomla 6's Atum toolbar does not render — so the button did nothing. Now wraps Joomla.submitbutton to open the modal for the backups.purgeModal task, keeping the selector as a fallback.

Test plan

• Profile editor → Archive tab shows "Keep Backups (days)" and "(count)".
• Set count=2, run 3 backups → oldest pruned (archive + log removed).
• Set days=1 → backups older than 1 day pruned on next run.
• Purge Old Backups toolbar button opens the modal; purge deletes as expected.

## Summary Two related backup-management fixes. ### Retention ("records / days to keep") - The `retention` fieldset was defined in `profile.xml` but **never rendered** in the profile editor, so `retention_days`/`retention_count` were invisible. Now rendered on the **Archive** tab. - Those columns were **read by nothing**, so no backup was ever pruned. Added `RetentionManager::prune()`, called from `completeRecord()` in both `BackupEngine` and `SteppedBackupEngine` after a backup finishes. - Policy: delete a `complete`/`warning` backup when **either** it is older than `retention_days` **or** it falls outside the newest `retention_count` copies. `0` = unlimited for that rule. Deleting a record also removes its archive + log file. - Corrected misleading language/schema text ("use global default" — no such global backup-retention setting exists) to "0 = unlimited". ### Purge Old Backups button - The modal only opened via a fragile selector match on the toolbar button's inline `onclick`, which Joomla 6's Atum toolbar does not render — so the button did nothing. Now wraps `Joomla.submitbutton` to open the modal for the `backups.purgeModal` task, keeping the selector as a fallback. ## Test plan - [ ] Profile editor → Archive tab shows "Keep Backups (days)" and "(count)". - [ ] Set count=2, run 3 backups → oldest pruned (archive + log removed). - [ ] Set days=1 → backups older than 1 day pruned on next run. - [ ] Purge Old Backups toolbar button opens the modal; purge deletes as expected.

jmiller added 1 commit 2026-07-04 20:26:01 +00:00

fix: enforce per-profile retention and repair Purge Old Backups button ... 10248b284a

Two related backup-management fixes.

Retention (records/days to keep):
- The retention fieldset was defined in profile.xml but never rendered
  in the profile editor, so retention_days/retention_count were invisible.
  Render the retention fieldset on the Archive tab.
- retention_days/retention_count were read by nothing, so they pruned no
  backups. Add RetentionManager::prune(), called from completeRecord() in
  both BackupEngine and SteppedBackupEngine after a backup finishes.
  Policy: delete a completed/warning backup when EITHER it is older than
  retention_days OR it falls outside the newest retention_count copies
  (0 = unlimited for that rule). Deleting a record also removes its
  archive and log file.
- Correct misleading language/schema text ("use global default" — no such
  global backup-retention setting exists) to "0 = unlimited".

Purge Old Backups button:
- The modal only opened via a fragile selector match on the toolbar
  button's inline onclick, which Joomla 6's Atum toolbar does not render,
  so the button did nothing. Wrap Joomla.submitbutton to open the modal
  for the backups.purgeModal task, keeping the selector as a fallback.

jmiller force-pushed fix/backup-retention-purge from 3bacf83d75 to 10248b284a 2026-07-04 20:26:01 +00:00 Compare

jmiller merged commit 2de2c5f917 into main 2026-07-04 20:26:21 +00:00

jmiller deleted branch fix/backup-retention-purge 2026-07-04 20:26:22 +00:00

jmiller referenced this pull request 2026-07-04 20:54:44 +00:00

docs(changelog): document 02.53.00–02.55.00 releases #205

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

component: admin

Admin UI and views

component: api

REST API

component: engine

Backup/restore engine

component: remote

Remote storage (FTP/GDrive)

component: scheduler

Scheduled tasks

bug

Something is not working

duplicate

This issue or pull request already exists

enhancement

New feature

help wanted

Need some help

invalid

Something is wrong

question

More information is needed

wontfix

This won't be fixed

No labels

Priority -

Type -

Milestone

No items

No Milestone

Assignees

Clear assignees

jmiller (Jonathan Miller)

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: MokoConsulting/MokoSuiteBackup#203