fix: remote destinations tab broken (Add Destination + stuck loading) #208

Merged

jmiller merged 2 commits from fix/remote-destinations-modal into main 2026-07-04 22:00:46 +00:00

Conversation 0 Commits 2 Files Changed 14

+21 -15

jmiller commented 2026-07-04 21:58:34 +00:00

Owner

Copy Link

Copy Source

Problem

On the profile editor's Remote tab (reported on suite.dev):

• The remote destinations table is stuck at "Loading…".
• Clicking Add Destination does nothing.

Root cause

Both symptoms share one cause. The DOMContentLoaded handler in tmpl/profile/edit.php instantiated the Bootstrap modal eagerly near the top:

const modal = bootstrap.Modal.getOrCreateInstance(modalEl);

In Joomla 6, Bootstrap ships as a deferred ES module, so window.bootstrap is not defined yet when this inline script runs at DOMContentLoaded. The reference throws a ReferenceError that aborts the entire handler — so loadRemotes() is never called (table stays "Loading…") and the Add Destination click listener is never bound (button dead).

The purge and stepped-backup modals were unaffected because they resolve bootstrap.Modal lazily inside their click handlers (by which time the module has loaded).

Fix

• Resolve the modal lazily via getModal() at click-time, matching the working modals — so the table load and button binding no longer depend on Bootstrap being ready at DOMContentLoaded.
• Explicitly load the bootstrap.modal web asset so window.bootstrap.Modal is registered.

Test plan

• Open a saved backup profile → Remote tab: the destinations table loads (shows rows or "none configured"), not stuck on "Loading…".
• Click Add Destination → the modal opens.
• Add/edit/save a destination → modal closes and the table refreshes.

## Problem On the profile editor's **Remote** tab (reported on suite.dev): - The remote destinations table is stuck at **"Loading…"**. - Clicking **Add Destination** does nothing. ## Root cause Both symptoms share one cause. The `DOMContentLoaded` handler in `tmpl/profile/edit.php` instantiated the Bootstrap modal **eagerly** near the top: ```js const modal = bootstrap.Modal.getOrCreateInstance(modalEl); ``` In Joomla 6, Bootstrap ships as a **deferred ES module**, so `window.bootstrap` is not defined yet when this inline script runs at `DOMContentLoaded`. The reference throws a `ReferenceError` that **aborts the entire handler** — so `loadRemotes()` is never called (table stays "Loading…") and the Add Destination click listener is never bound (button dead). The purge and stepped-backup modals were unaffected because they resolve `bootstrap.Modal` **lazily inside their click handlers** (by which time the module has loaded). ## Fix - Resolve the modal **lazily** via `getModal()` at click-time, matching the working modals — so the table load and button binding no longer depend on Bootstrap being ready at `DOMContentLoaded`. - Explicitly load the `bootstrap.modal` web asset so `window.bootstrap.Modal` is registered. ## Test plan - [ ] Open a **saved** backup profile → Remote tab: the destinations table loads (shows rows or "none configured"), not stuck on "Loading…". - [ ] Click **Add Destination** → the modal opens. - [ ] Add/edit/save a destination → modal closes and the table refreshes.

jmiller added 1 commit 2026-07-04 22:00:19 +00:00

fix(profile): remote destinations tab broken — lazy-init Bootstrap modal ... 4ca9e23630

The remote destinations table stayed stuck at "Loading…" and the "Add
Destination" button did nothing. Root cause: the profile-edit DOMContentLoaded
handler instantiated the Bootstrap modal eagerly at the top
(`bootstrap.Modal.getOrCreateInstance`). In Joomla 6, Bootstrap loads as a
deferred ES module, so `bootstrap` is undefined at DOMContentLoaded — the
reference threw a ReferenceError that aborted the entire handler, so
loadRemotes() never ran and the Add button was never bound. (The purge and
stepped-backup modals worked because they resolve the modal lazily inside
click handlers.)

- Resolve the modal lazily via getModal() at click-time (matches the working modals)
- Explicitly load the bootstrap.modal web asset so window.bootstrap.Modal is registered

Claude-Session: https://claude.ai/code/session_01WbGBN9VyRK61zczYWcCQ2i

jmiller force-pushed fix/remote-destinations-modal from 3ef36fd41e to 4ca9e23630 2026-07-04 22:00:19 +00:00 Compare

jmiller merged commit 183b2d2d6f into main 2026-07-04 22:00:46 +00:00

jmiller deleted branch fix/remote-destinations-modal 2026-07-04 22:00:49 +00:00

jmiller referenced this pull request 2026-07-04 22:10:27 +00:00

fix: remote destinations tab broken (cascade to dev) #209

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

component: admin

Admin UI and views

component: api

REST API

component: engine

Backup/restore engine

component: remote

Remote storage (FTP/GDrive)

component: scheduler

Scheduled tasks

bug

Something is not working

duplicate

This issue or pull request already exists

enhancement

New feature

help wanted

Need some help

invalid

Something is wrong

question

More information is needed

wontfix

This won't be fixed

No labels

Priority -

Type -

Milestone

No items

No Milestone

Assignees

Clear assignees

jmiller (Jonathan Miller)

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: MokoConsulting/MokoSuiteBackup#208