.mokogitea/workflows/issue-branch.yml

@@ -5,7 +5,7 @@
 # FILE INFORMATION
 # DEFGROUP: MokoGitea.Workflow
 # INGROUP: mokocli.Automation
-# VERSION: 02.57.04
+# VERSION: 02.57.05
 # BRIEF: Auto-create feature branch when an issue is opened
 
 name: "Universal: Issue Branch"

CHANGELOG.md

@@ -3,6 +3,7 @@
 ## [Unreleased]
 
 ### Fixed
+- Admin menu / duplicate-component fallout: (a) the orphaned `com_component-mokosuitebackup` is now removed in **preflight** too, so its "Backup" menu no longer collides on install ("The alias backup is already being used"); (b) `ensureSubmenuItems()` **recreates the top-level "Backup" menu** if it was deleted, instead of giving up — so Backup no longer disappears from the admin menu (and the cPanel module / MokoSuiteClient can find it again); (c) the component menu label now uses the short constant `COM_MOKOJOOMBACKUP_SHORT`. (#213 fallout)
 - Installer no longer aborts on MySQL 8 with "This command is not supported in the prepared statement protocol yet" (error 1295). The legacy remote-column purge migration (`02.56.01.sql`) used `PREPARE`/`EXECUTE`/`DEALLOCATE`, which Joomla's installer rejects; the drop now runs in the package installer script via an INFORMATION_SCHEMA-gated plain `ALTER` (portable across MariaDB and MySQL 8). (#213 update path)
 
 ## [02.57.00] --- 2026-07-05

SECURITY.md

@@ -23,7 +23,7 @@ DEFGROUP: Template-Joomla
 INGROUP: Template-Joomla.Documentation
 REPO: https://git.mokoconsulting.tech/MokoConsulting/Template-Joomla
 PATH: /SECURITY.md
-VERSION: 02.57.04
+VERSION: 02.57.05
 BRIEF: Security vulnerability reporting and handling policy
 -->
 

source/packages/com_mokosuitebackup/mokosuitebackup.xml

@@ -17,7 +17,7 @@
 		display label there.
 	-->
 	<name>MokoSuiteBackup</name>
-	<version>02.57.04</version>
+	<version>02.57.05</version>
 	<creationDate>2026-06-02</creationDate>
 	<author>Moko Consulting</author>
 	<authorEmail>hello@mokoconsulting.tech</authorEmail>
@@ -47,7 +47,7 @@
 	</update>
 
 	<administration>
-		<menu img="class:archive">Backup</menu>
+		<menu img="class:archive">COM_MOKOJOOMBACKUP_SHORT</menu>
 		<submenu>
 			<menu link="option=com_mokosuitebackup&amp;view=dashboard"
 				  img="class:home"

source/packages/com_mokosuitebackup/sql/updates/mysql/02.57.05.sql

@@ -0,0 +1 @@
+/* 02.57.05 — no schema changes */

source/packages/mod_mokosuitebackup_cpanel/mod_mokosuitebackup_cpanel.xml

@@ -8,7 +8,7 @@
  -->
 <extension type="module" client="administrator" method="upgrade">
 	<name>Module - MokoSuiteBackup - cPanel</name>
-	<version>02.57.04</version>
+	<version>02.57.05</version>
 	<creationDate>2026-06-23</creationDate>
 	<author>Moko Consulting</author>
 	<authorEmail>hello@mokoconsulting.tech</authorEmail>

source/packages/plg_actionlog_mokosuitebackup/mokosuitebackup.xml

@@ -7,7 +7,7 @@
  -->
 <extension type="plugin" group="actionlog" method="upgrade">
 	<name>Action Log - MokoSuiteBackup</name>
-	<version>02.57.04</version>
+	<version>02.57.05</version>
 	<creationDate>2026-06-04</creationDate>
 	<author>Moko Consulting</author>
 	<authorEmail>hello@mokoconsulting.tech</authorEmail>

source/packages/plg_console_mokosuitebackup/mokosuitebackup.xml

@@ -7,7 +7,7 @@
  -->
 <extension type="plugin" group="console" method="upgrade">
 	<name>Console - MokoSuiteBackup</name>
-	<version>02.57.04</version>
+	<version>02.57.05</version>
 	<creationDate>2026-06-04</creationDate>
 	<author>Moko Consulting</author>
 	<authorEmail>hello@mokoconsulting.tech</authorEmail>

source/packages/plg_content_mokosuitebackup/mokosuitebackup.xml

@@ -7,7 +7,7 @@
  -->
 <extension type="plugin" group="content" method="upgrade">
 	<name>Content - MokoSuiteBackup</name>
-	<version>02.57.04</version>
+	<version>02.57.05</version>
 	<creationDate>2026-06-04</creationDate>
 	<author>Moko Consulting</author>
 	<authorEmail>hello@mokoconsulting.tech</authorEmail>

source/packages/plg_quickicon_mokosuitebackup/mokosuitebackup.xml

@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <extension type="plugin" group="quickicon" method="upgrade">
 	<name>Quick Icon - MokoSuiteBackup</name>
-	<version>02.57.04</version>
+	<version>02.57.05</version>
 	<creationDate>2026-06-02</creationDate>
 	<author>Moko Consulting</author>
 	<authorEmail>hello@mokoconsulting.tech</authorEmail>

source/packages/plg_system_mokosuitebackup/mokosuitebackup.xml

@@ -7,7 +7,7 @@
  -->
 <extension type="plugin" group="system" method="upgrade">
 	<name>System - MokoSuiteBackup</name>
-	<version>02.57.04</version>
+	<version>02.57.05</version>
 	<creationDate>2026-06-02</creationDate>
 	<author>Moko Consulting</author>
 	<authorEmail>hello@mokoconsulting.tech</authorEmail>

source/packages/plg_task_mokosuitebackup/mokosuitebackup.xml

@@ -7,7 +7,7 @@
  -->
 <extension type="plugin" group="task" method="upgrade">
 	<name>Task - MokoSuiteBackup</name>
-	<version>02.57.04</version>
+	<version>02.57.05</version>
 	<creationDate>2026-06-02</creationDate>
 	<author>Moko Consulting</author>
 	<authorEmail>hello@mokoconsulting.tech</authorEmail>

source/packages/plg_webservices_mokosuitebackup/mokosuitebackup.xml

@@ -7,7 +7,7 @@
  -->
 <extension type="plugin" group="webservices" method="upgrade">
 	<name>Web Services - MokoSuiteBackup</name>
-	<version>02.57.04</version>
+	<version>02.57.05</version>
 	<creationDate>2026-06-02</creationDate>
 	<author>Moko Consulting</author>
 	<authorEmail>hello@mokoconsulting.tech</authorEmail>

source/pkg_mokosuitebackup.xml

@@ -8,7 +8,7 @@
 <extension type="package" method="upgrade">
 	<name>Package - MokoSuiteBackup</name>
 	<packagename>mokosuitebackup</packagename>
-	<version>02.57.04</version>
+	<version>02.57.05</version>
 	<creationDate>2026-06-02</creationDate>
 	<author>Moko Consulting</author>
 	<authorEmail>hello@mokoconsulting.tech</authorEmail>

source/script.php

@@ -77,6 +77,13 @@ class Pkg_MokoSuiteBackupInstallerScript
 			$this->backupDownloadKey();
 		}
 
+		/* Remove any orphaned mis-registered component BEFORE the component install
+		   recreates its admin menu. The orphan (element com_component-mokosuitebackup)
+		   owns a "Backup" menu with alias "backup"; if it survives, the real
+		   component's menu creation collides ("The alias backup is already being used")
+		   and the whole install aborts. */
+		$this->removeOrphanedComponent();
+
 		return true;
 	}
 
@@ -622,23 +629,7 @@ class Pkg_MokoSuiteBackupInstallerScript
 		try {
 			$db = Factory::getDbo();
 
-			/* Find the parent menu item for our component */
-			$query = $db->getQuery(true)
-				->select([$db->quoteName('id'), $db->quoteName('menutype')])
-				->from($db->quoteName('#__menu'))
-				->where($db->quoteName('client_id') . ' = 1')
-				->where($db->quoteName('level') . ' = 1')
-				->where($db->quoteName('link') . ' LIKE ' . $db->quote('index.php?option=com_mokosuitebackup%'))
-				->setLimit(1);
-			$db->setQuery($query);
-			$parent = $db->loadObject();
-
-			if (!$parent) {
-				error_log('MokoSuiteBackup: ensureSubmenuItems() — parent menu item not found');
-				return;
-			}
-
-			/* Get the component extension_id */
+			/* Component extension_id first — needed to (re)create the parent menu. */
 			$query = $db->getQuery(true)
 				->select($db->quoteName('extension_id'))
 				->from($db->quoteName('#__extensions'))
@@ -653,6 +644,41 @@ class Pkg_MokoSuiteBackupInstallerScript
 				return;
 			}
 
+			/* Find the top-level "Backup" parent menu item for our component */
+			$query = $db->getQuery(true)
+				->select([$db->quoteName('id'), $db->quoteName('menutype')])
+				->from($db->quoteName('#__menu'))
+				->where($db->quoteName('client_id') . ' = 1')
+				->where($db->quoteName('level') . ' = 1')
+				->where($db->quoteName('link') . ' LIKE ' . $db->quote('index.php?option=com_mokosuitebackup%'))
+				->setLimit(1);
+			$db->setQuery($query);
+			$parent = $db->loadObject();
+
+			/* Self-heal: if the top-level menu was deleted (e.g. by a failed install
+			   after the duplicate-component mess), recreate it — otherwise the whole
+			   Backup menu stays gone and dependents (cPanel module, MokoSuiteClient)
+			   can't locate the component. */
+			if (!$parent) {
+				$parent = $this->createTopMenu($componentId);
+
+				if (!$parent) {
+					error_log('MokoSuiteBackup: ensureSubmenuItems() — parent menu missing and could not be created');
+					return;
+				}
+			}
+
+			/* Keep the top-level menu label on the short constant and owned by the
+			   real component. */
+			$db->setQuery(
+				$db->getQuery(true)
+					->update($db->quoteName('#__menu'))
+					->set($db->quoteName('title') . ' = ' . $db->quote('COM_MOKOJOOMBACKUP_SHORT'))
+					->set($db->quoteName('component_id') . ' = ' . (int) $componentId)
+					->where($db->quoteName('id') . ' = ' . (int) $parent->id)
+			);
+			$db->execute();
+
 			foreach ($submenus as $submenu) {
 				/* Check if this submenu item already exists */
 				$query = $db->getQuery(true)
@@ -718,6 +744,59 @@ class Pkg_MokoSuiteBackupInstallerScript
 		}
 	}
 
+	/**
+	 * Create the top-level "Backup" admin menu item for the component when it is
+	 * missing (deleted by a failed install / the duplicate-component fallout).
+	 * Label uses the short constant. Returns a lightweight {id, menutype} object,
+	 * or null on failure.
+	 *
+	 * @param   int  $componentId  Extension id of com_mokosuitebackup
+	 *
+	 * @return  object|null
+	 */
+	private function createTopMenu(int $componentId): ?object
+	{
+		try {
+			$table = Factory::getApplication()
+				->bootComponent('com_menus')
+				->getMVCFactory()
+				->createTable('Menu', 'Administrator');
+
+			$table->menutype     = 'main';
+			$table->title        = 'COM_MOKOJOOMBACKUP_SHORT';
+			$table->alias        = 'backup';
+			$table->link         = 'index.php?option=com_mokosuitebackup';
+			$table->type         = 'component';
+			$table->published    = 1;
+			$table->parent_id    = 1;
+			$table->level        = 1;
+			$table->component_id = $componentId;
+			$table->client_id    = 1;
+			$table->img          = 'class:archive';
+			$table->params       = '{}';
+			$table->language     = '*';
+			$table->access       = 1;
+
+			$table->setLocation(1, 'last-child');
+
+			if (!$table->check() || !$table->store()) {
+				error_log('MokoSuiteBackup: createTopMenu() failed: ' . $table->getError());
+
+				return null;
+			}
+
+			$obj           = new \stdClass();
+			$obj->id       = (int) $table->id;
+			$obj->menutype = 'main';
+
+			return $obj;
+		} catch (\Throwable $e) {
+			error_log('MokoSuiteBackup: createTopMenu() exception: ' . $e->getMessage());
+
+			return null;
+		}
+	}
+
 	private function fixPackageClientId(): void
 	{
 		try {