MokoConsulting/MokoSuiteNPO
1
0
Fork 0
Code Issues 18 Pull Requests 2 Releases 3 Wiki Activity

feat(menu): admin menu short-name constant COM_MOKOSUITENPO_SHORT (#37) #41

Merged
jmiller merged 5 commits from fix/short-menu-constant into dev 2026-07-07 10:15:46 +00:00
Conversation 0 Commits 5 Files Changed 4
+12 -6
jmiller commented 2026-07-06 22:46:17 +00:00
Owner
Copy Link
Copy Source

Summary

Resolves the admin-menu short-name issue for com_mokosuitenpo. The component manifest previously pointed the admin <menu> at a hardcoded literal MokoSuite NPO. This PR points it at a translatable short-name constant and wires the admin language so the constant resolves.

Path taken: CREATED + WIRED (recon confirmed no com_mokosuitenpo.sys.ini existed anywhere in the repo, and <administration> had no <languages> block).

Changes

  1. Created source/packages/com_mokosuitenpo/admin/language/en-GB/com_mokosuitenpo.sys.ini: 
    COM_MOKOSUITENPO="MokoSuite NPO"
COM_MOKOSUITENPO_SHORT="NPO"
COM_MOKOSUITENPO_XML_DESCRIPTION="MokoSuite NPO component."
  2. Manifest mokosuitenpo.xml:
    • <menu>MokoSuite NPO</menu> → <menu>COM_MOKOSUITENPO_SHORT</menu>
    • Added <folder>language</folder> to the admin <files folder="admin"> block
    • Wired <languages folder="admin/language"><language tag="en-GB">en-GB/com_mokosuitenpo.sys.ini</language></languages> into <administration> (idiom copied from sibling com_mokosuitehq)
    • Also converted the literal <description> to the COM_MOKOSUITENPO_XML_DESCRIPTION constant now that it is defined

Menu label: MokoSuite NPO (literal) → NPO (via COM_MOKOSUITENPO_SHORT).

Resolves #37. Supersedes #39 (the COM_MOKOSUITENPO_SHORT_NAME duplicate) — this uses the _SHORT naming that matches the sibling components (COM_MOKOSUITEHQ_SHORT).

Do not merge — for review.

https://claude.ai/code/session_01B9aZHSWbiiZykJD88pYx8R

## Summary Resolves the admin-menu short-name issue for `com_mokosuitenpo`. The component manifest previously pointed the admin `<menu>` at a hardcoded literal `MokoSuite NPO`. This PR points it at a translatable short-name constant and wires the admin language so the constant resolves. **Path taken: CREATED + WIRED** (recon confirmed no `com_mokosuitenpo.sys.ini` existed anywhere in the repo, and `<administration>` had no `<languages>` block). ### Changes 1. **Created** `source/packages/com_mokosuitenpo/admin/language/en-GB/com_mokosuitenpo.sys.ini`: ```ini COM_MOKOSUITENPO="MokoSuite NPO" COM_MOKOSUITENPO_SHORT="NPO" COM_MOKOSUITENPO_XML_DESCRIPTION="MokoSuite NPO component." ``` 2. **Manifest** `mokosuitenpo.xml`: - `<menu>MokoSuite NPO</menu>` → `<menu>COM_MOKOSUITENPO_SHORT</menu>` - Added `<folder>language</folder>` to the admin `<files folder="admin">` block - Wired `<languages folder="admin/language"><language tag="en-GB">en-GB/com_mokosuitenpo.sys.ini</language></languages>` into `<administration>` (idiom copied from sibling `com_mokosuitehq`) - Also converted the literal `<description>` to the `COM_MOKOSUITENPO_XML_DESCRIPTION` constant now that it is defined Menu label: **`MokoSuite NPO` (literal) → `NPO` (via `COM_MOKOSUITENPO_SHORT`)**. Resolves #37. Supersedes #39 (the `COM_MOKOSUITENPO_SHORT_NAME` duplicate) — this uses the `_SHORT` naming that matches the sibling components (`COM_MOKOSUITEHQ_SHORT`). Do not merge — for review. https://claude.ai/code/session_01B9aZHSWbiiZykJD88pYx8R
jmiller added 2 commits 2026-07-06 22:46:17 +00:00
feat(menu): add COM_MOKOSUITENPO_SHORT short-name constant (#37)
Universal: Pre-Release / Build Pre-Release (${{ inputs.stability || github.ref_name }}) (push) Successful in 12s
Details
9e314a86cc 
Claude-Session: https://claude.ai/code/session_01B9aZHSWbiiZykJD88pYx8R
feat(menu): use COM_MOKOSUITENPO_SHORT + wire admin language (#37)
Universal: PR Check / Branch Policy (pull_request) Successful in 1s
Details
Universal: PR Check / Validate PR (pull_request) Failing after 4s
Details
Universal: PR Check / Secret Scan (pull_request) Successful in 5s
Details
Joomla: Metadata Validation / Validate Joomla Metadata (pull_request) Successful in 49s
Details
Universal: Pre-Release / Build Pre-Release (${{ inputs.stability || github.ref_name }}) (push) Successful in 19s
Details
Universal: PR Check / Build RC Package (pull_request) Has been cancelled
Details
Universal: PR Check / Report Issues (pull_request) Has been cancelled
Details
9d7482c3e8 
Claude-Session: https://claude.ai/code/session_01B9aZHSWbiiZykJD88pYx8R
jmiller added 1 commit 2026-07-06 22:46:47 +00:00
chore(version): pre-release bump to 01.07.31-dev [skip ci] d3f60b2c00
jmiller added 1 commit 2026-07-06 22:47:22 +00:00
chore(version): pre-release bump to 01.07.32-dev [skip ci] fbd2d92b93
jmiller added 1 commit 2026-07-06 22:47:37 +00:00
chore(version): pre-release bump to 01.07.33-dev [skip ci]
RC Revert / Rename rc/ back to dev/ (pull_request) Has been skipped
Details
Branch Cleanup / Delete merged branch (pull_request) Successful in 2s
Details
fe25cae9f9
jmiller merged commit ac0b0ea6ff into dev 2026-07-07 10:15:46 +00:00
jmiller deleted branch fix/short-menu-constant 2026-07-07 10:15:47 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No labels
Priority -
Type -
Milestone
No items
No Milestone
Assignees
Clear assignees
jmiller (Jonathan Miller)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MokoConsulting/MokoSuiteNPO#41
Delete Branch "fix/short-menu-constant"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?