fix: PHP_BINARY interpolation on Windows #217

Merged

jmiller merged 1 commits from dev into main 2026-05-30 15:16:29 +00:00

Conversation 0 Commits 1 Files Changed 2

+22 -22

jmiller commented 2026-05-30 15:16:22 +00:00

Owner

Copy Link

Copy Source

No description provided.

jmiller added 1 commit 2026-05-30 15:16:22 +00:00

fix(cli): use concatenation for PHP_BINARY in exec calls ... 7f2f41d5c4

String interpolation with escapeshellarg'd PHP_BINARY breaks on
Windows because curly braces in "{$php}" get consumed by PHP's
complex variable syntax when the value contains quotes.

Authored-by: Moko Consulting
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

jmiller added 1 commit 2026-05-30 15:16:22 +00:00

fix(cli): use concatenation for PHP_BINARY in exec calls ... 7f2f41d5c4

String interpolation with escapeshellarg'd PHP_BINARY breaks on
Windows because curly braces in "{$php}" get consumed by PHP's
complex variable syntax when the value contains quotes.

Authored-by: Moko Consulting
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

jmiller merged commit bc8f9830f2 into main 2026-05-30 15:16:29 +00:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

automation

Automated processes or scripts

breaking-change

Breaking API or functionality change

build

Build system changes

ci-cd

CI/CD pipeline changes

config

Configuration file changes

css

CSS/styling changes

dependencies

Dependency updates

deploy-failure

Automated deploy failure tracking

docker

Docker configuration changes

documentation

Documentation changes

dolibarr

Dolibarr module or extension

generic

Generic project or library

good first issue

Good for newcomers

health-check

Repository health check results

health: excellent

Health score 90-100

health: fair

Health score 50-69

health: good

Health score 70-89

health: poor

Health score below 50

help wanted

Extra attention needed

html

HTML template changes

javascript

JavaScript code changes

joomla

Joomla extension or component

mokostandards

MokoStandards compliance

needs-review

Awaiting code review

php

PHP code changes

push-failure

File push failure requiring attention

python

Python code changes

security

Security-related changes

size/l

Large change (101-300 lines)

size/m

Medium change (31-100 lines)

size/s

Small change (11-30 lines)

size/xl

Extra large change (301-1000 lines)

size/xs

Extra small change (1-10 lines)

size/xxl

Extremely large change (1000+ lines)

standards-drift

Repository drifted from MokoStandards

standards-update

MokoStandards sync update

sync-failure

Bulk sync failure requiring attention

sync-report

Bulk sync run report

template-validation-failure

Template workflow validation failure

tests

Test suite changes

type: bug

Something isn't working

type: chore

Maintenance tasks

type: enhancement

Enhancement to existing feature

type: feature

New feature or request

type: refactor

Code refactoring

type: version

Version-related change

typescript

TypeScript code changes

version

Version bump or release

version-drift

Version mismatch detected

work-in-progress

Work in progress, not ready for merge

No labels

Priority -

Type -

Milestone

No items

No Milestone

Assignees

Clear assignees

jmiller (Jonathan Miller)

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: MokoConsulting/mokoplatform#217